asdf2014 commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210461393
########## File path: extensions-contrib/kafka-eight-simpleConsumer/src/main/java/io/druid/firehose/kafka/KafkaSimpleConsumer.java ########## @@ -74,10 +75,10 @@ private List<HostAndPort> replicaBrokers; private SimpleConsumer consumer = null; - private static final int SO_TIMEOUT = 30000; + private static final int SO_TIMEOUT_MILLIS = (int) TimeUnit.SECONDS.toMillis(30); Review comment: Yes, I have tried it before. But, the constructor of `SimpleConsumer` needs an `int` type `soTimeout` parameter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
