gianm commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r209746794
##########
File path: sql/src/main/java/io/druid/sql/calcite/planner/Calcites.java
##########
@@ -98,11 +103,30 @@ public static Charset defaultCharset()
return DEFAULT_CHARSET;
}
- public static SchemaPlus createRootSchema(final Schema druidSchema, final
AuthorizerMapper authorizerMapper)
+ public static SchemaPlus createRootSchema(
+ final TimelineServerView serverView,
+ final Schema druidSchema,
+ final AuthorizerMapper authorizerMapper,
+ final DruidLeaderClient coordinatorDruidLeaderClient,
+ final DruidLeaderClient overlordDruidLeaderClient,
+ final ObjectMapper jsonMapper
+ )
{
final SchemaPlus rootSchema = CalciteSchema.createRootSchema(false,
false).plus();
rootSchema.add(DruidSchema.NAME, druidSchema);
rootSchema.add(InformationSchema.NAME, new InformationSchema(rootSchema,
authorizerMapper));
+ if (serverView instanceof BrokerServerView) {
Review comment:
Is this really necessary? It looks like you added `getClients` to
TimelineServerView, so we shouldn't need to cast it to a BrokerServerView.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
