jihoonson commented on a change in pull request #6207: Fix timeout in
KafkaSupervisorTest.testCheckpointForInactiveTaskGroup
URL: https://github.com/apache/incubator-druid/pull/6207#discussion_r212125031
##########
File path:
extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java
##########
@@ -2115,12 +2115,8 @@ public void testCheckpointForInactiveTaskGroup()
verifyAll();
- while (serviceEmitter.getStackTrace() != null) {
- Thread.sleep(100);
- }
-
- Assert.assertNull(serviceEmitter.getStackTrace());
- Assert.assertNull(serviceEmitter.getExceptionMessage());
+ Assert.assertNull(serviceEmitter.getStackTrace(),
serviceEmitter.getStackTrace());
Review comment:
Yeah, the title looks somewhat confusing :(. Do you have a better idea?
I thought it would be great if the CI for this PR shows something
interesting, but unfortunately it succeeded. I can restart it until I find
something, or check other PRs if they fail with some stack traces. I don't have
a strong opinion here, but I would say this PR gives us a small benefit by
making CI jobs fail faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
