himanshug commented on a change in pull request #6207: Fix timeout in
KafkaSupervisorTest.testCheckpointForInactiveTaskGroup
URL: https://github.com/apache/incubator-druid/pull/6207#discussion_r212129671
##########
File path:
extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java
##########
@@ -2115,12 +2115,8 @@ public void testCheckpointForInactiveTaskGroup()
verifyAll();
- while (serviceEmitter.getStackTrace() != null) {
- Thread.sleep(100);
- }
-
- Assert.assertNull(serviceEmitter.getStackTrace());
- Assert.assertNull(serviceEmitter.getExceptionMessage());
+ Assert.assertNull(serviceEmitter.getStackTrace(),
serviceEmitter.getStackTrace());
Review comment:
maybe, "Add debug information to expose transient failure cause in
KafkaSupervisorTest.testCheckpointForInactiveTaskGroup", if this PR is merged
without actually fixing.
I'm approving it so feel free to merge whenever you want after trying out
the builds here. I triggered one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
