jihoonson commented on a change in pull request #6206: Fix NPE in 
KafkaSupervisor.checkpointTaskGroup
URL: https://github.com/apache/incubator-druid/pull/6206#discussion_r212173406
 
 

 ##########
 File path: 
extensions-core/kafka-indexing-service/src/main/java/io/druid/indexing/kafka/supervisor/KafkaSupervisor.java
 ##########
 @@ -1714,6 +1755,8 @@ private void checkCurrentTaskState() throws 
ExecutionException, InterruptedExcep
           continue;
         }
 
+        Preconditions.checkNotNull(taskData.status, "task[%s] has a null 
status", taskId);
 
 Review comment:
   Same here. This should never happen. NPE would throw if `taskData.status` is 
null and this is just a sanity code to see what's null on the potential NPE. I 
improved the error message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to