himanshug commented on issue #6223: make COMPLEX column filterable in Druid code URL: https://github.com/apache/incubator-druid/pull/6223#issuecomment-415621456 @gianm agree that columns can be filterable without bitmap indexes. however, independently, only use of `Filter.FILTERABLE_TYPE` is in `ColumnSelectorBitmapIndexSelector.columnSupportsFiltering(column)` which looks like ``` private static boolean columnSupportsFiltering(Column column) { ValueType columnType = column.getCapabilities().getType(); return Filters.FILTERABLE_TYPES.contains(columnType); } ``` and at its call sites, it is used to check whether to work with an empty bitmap or get one from column. it appears, everything would stay exactly same even if I changed above implementation to... ``` private static boolean columnSupportsFiltering(Column column) { return column.getCapabilities().hasBitmapIndexes(); } ``` with above done, there is no more any usage of `Filter.FILTERABLE_TYPE` . I must be missing something.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
