leventov opened a new pull request #6226: Prohibit some Random usage patterns URL: https://github.com/apache/incubator-druid/pull/6226 - `Math.abs(random.nextInt())` doesn't guarantee positivity - `random.nextInt() % x` - `new Random()` should never be used, `ThreadLocalRandom.current()` or `SplittableRandom` instead. I also replaced most `new Random(SOME_CONSTANT_SEED)` in benchmarks with `ThreadLocalRandom.current()` because benchmarks shouldn't generally be always identical, randomness between the runs could make results statistically more reliable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
