fjy closed pull request #6238: [Backport] SQL: Fix selecting BOOLEAN type in JDBC. URL: https://github.com/apache/incubator-druid/pull/6238
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/sql/src/main/java/io/druid/sql/calcite/rel/QueryMaker.java b/sql/src/main/java/io/druid/sql/calcite/rel/QueryMaker.java index ed006a8b95a..3c063f82b36 100644 --- a/sql/src/main/java/io/druid/sql/calcite/rel/QueryMaker.java +++ b/sql/src/main/java/io/druid/sql/calcite/rel/QueryMaker.java @@ -385,6 +385,8 @@ public void remove() return ColumnMetaData.Rep.of(Float.class); } else if (sqlType == SqlTypeName.DOUBLE || sqlType == SqlTypeName.DECIMAL) { return ColumnMetaData.Rep.of(Double.class); + } else if (sqlType == SqlTypeName.BOOLEAN) { + return ColumnMetaData.Rep.of(Boolean.class); } else if (sqlType == SqlTypeName.OTHER) { return ColumnMetaData.Rep.of(Object.class); } else { diff --git a/sql/src/test/java/io/druid/sql/avatica/DruidAvaticaHandlerTest.java b/sql/src/test/java/io/druid/sql/avatica/DruidAvaticaHandlerTest.java index a9781886a43..b13035b2a5f 100644 --- a/sql/src/test/java/io/druid/sql/avatica/DruidAvaticaHandlerTest.java +++ b/sql/src/test/java/io/druid/sql/avatica/DruidAvaticaHandlerTest.java @@ -41,12 +41,12 @@ import io.druid.java.util.common.StringUtils; import io.druid.math.expr.ExprMacroTable; import io.druid.server.DruidNode; -import io.druid.server.security.NoopEscalator; import io.druid.server.security.AuthConfig; import io.druid.server.security.AuthTestUtils; import io.druid.server.security.AuthenticatorMapper; import io.druid.server.security.AuthorizerMapper; import io.druid.server.security.Escalator; +import io.druid.server.security.NoopEscalator; import io.druid.sql.calcite.planner.Calcites; import io.druid.sql.calcite.planner.DruidOperatorTable; import io.druid.sql.calcite.planner.PlannerConfig; @@ -287,6 +287,21 @@ public void testFieldAliasingSelect() throws Exception ); } + @Test + public void testSelectBoolean() throws Exception + { + final ResultSet resultSet = client.createStatement().executeQuery( + "SELECT dim2, dim2 IS NULL AS isnull FROM druid.foo LIMIT 1" + ); + + Assert.assertEquals( + ImmutableList.of( + ImmutableMap.of("dim2", "a", "isnull", false) + ), + getRows(resultSet) + ); + } + @Test public void testExplainSelectCount() throws Exception { ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org