drcrallen commented on a change in pull request #6219: Add optional `name` to
top level of FilteredAggregatorFactory
URL: https://github.com/apache/incubator-druid/pull/6219#discussion_r213056500
##########
File path:
processing/src/main/java/io/druid/query/aggregation/FilteredAggregatorFactory.java
##########
@@ -112,7 +127,11 @@ public Object finalizeComputation(Object object)
@Override
public String getName()
{
- return delegate.getName();
+ String name = delegate.getName();
+ if (Strings.isNullOrEmpty(name)) {
+ name = this.name;
+ }
+ return name;
Review comment:
@nishantmonu51 fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
