himanshug commented on a change in pull request #5872: add method
getRequiredColumns for DimFilter
URL: https://github.com/apache/incubator-druid/pull/5872#discussion_r213452493
##########
File path: processing/src/main/java/io/druid/query/filter/DimFilter.java
##########
@@ -75,4 +77,9 @@
* determine for this DimFilter.
*/
RangeSet<String> getDimensionRangeSet(String dimension);
+
+ /**
+ * @return a HashSet that represents all columns' name which the DimFilter
required to do filter.
+ */
+ HashSet<String> getRequiredColumns();
Review comment:
Can we have the return type be `Set<String>` instead so that single column
cases can just return `ImmutableSet.of(col)` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
