jihoonson commented on a change in pull request #5913: Move Caching Cluster
Client to java streams and allow parallel intermediate merges
URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213474326
##########
File path: processing/src/main/java/io/druid/query/QueryContexts.java
##########
@@ -218,6 +239,12 @@
return val == null ? defaultValue : Numbers.parseLong(val);
}
+ static <T> OptionalLong parseLong(Query<T> query, String key)
Review comment:
All other similar methods return a primitive, so please make this
consistent. Maybe it can return a default value if it's not in the context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
