a2l007 commented on a change in pull request #6263: Add ability to specify list
of task ports
URL: https://github.com/apache/incubator-druid/pull/6263#discussion_r213748077
##########
File path:
indexing-service/src/main/java/io/druid/indexing/overlord/PortFinder.java
##########
@@ -27,16 +27,19 @@
import java.io.IOException;
import java.net.ServerSocket;
import java.net.SocketException;
+import java.util.List;
import java.util.Set;
public class PortFinder
{
private final Set<Integer> usedPorts = Sets.newHashSet();
private final int startPort;
+ private final List<Integer> candidatePorts;
- public PortFinder(int startPort)
+ public PortFinder(int startPort, List<Integer> candidatePorts)
Review comment:
Instead of modifying the existing constructor, you could have a separate
constructor with both the properties and to be used only when `candidatePorts`
is non-empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
