drcrallen commented on a change in pull request #5913: Move Caching Cluster
Client to java streams and allow parallel intermediate merges
URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213772578
##########
File path: processing/src/main/java/io/druid/query/QueryContexts.java
##########
@@ -218,6 +239,12 @@
return val == null ? defaultValue : Numbers.parseLong(val);
}
+ static <T> OptionalLong parseLong(Query<T> query, String key)
Review comment:
ah, I remember now. If this setting is not present in the context, then the
parallel merging is not used and the legacy sequence merge is used instead. As
such, I can either use a "default" value and check for that, or just return the
optional, and choose the code branch based on if it is present or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
