leventov commented on a change in pull request #5913: Move Caching Cluster 
Client to java streams and allow parallel intermediate merges
URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213852342
 
 

 ##########
 File path: server/src/main/java/io/druid/client/DirectDruidClient.java
 ##########
 @@ -590,6 +591,27 @@ private void init()
     {
       if (jp == null) {
         try {
+          // Safety for if we are in a FJP
+          ForkJoinPool.managedBlock(new ForkJoinPool.ManagedBlocker()
 
 Review comment:
   @jihoonson performance penalty if running outside of a ForkJoinPool should 
be minimal.
   
   @drcrallen please extract an utility method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to