gianm commented on a change in pull request #6076: Mutual TLS support
URL: https://github.com/apache/incubator-druid/pull/6076#discussion_r218575985
##########
File path: server/src/main/java/org/apache/druid/server/security/TLSUtils.java
##########
@@ -39,28 +44,77 @@ public static SSLContext createSSLContext(
String trustStoreType,
String trustStorePath,
String trustStoreAlgorithm,
- PasswordProvider trustStorePasswordProvider
+ PasswordProvider trustStorePasswordProvider,
+ String keyStoreType,
+ String keyStorePath,
+ String keyStoreAlgorithm,
+ String certAlias,
+ PasswordProvider keyStorePasswordProvider,
+ PasswordProvider keyManagerFactoryPasswordProvider
Review comment:
This method's arg list is getting super long. It would be nicer, although
not required, to use a builder instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
