clintropolis commented on a change in pull request #6272: Add
suspend|resume|terminate all supervisors endpoints.
URL: https://github.com/apache/incubator-druid/pull/6272#discussion_r219351933
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResource.java
##########
@@ -260,6 +260,39 @@ public Response terminate(@PathParam("id") final String
id)
);
}
+ @POST
+ @Path("/suspendAll")
Review comment:
I don't feel like the `All` suffix is necessary for these methods, it seems
implied since the url path doesn't specify a supervisor id, and doesn't appear
to be a common convention in other API paths that do things to multiple things.
That said, the base path for the supervisor api probably should have been
`/druid/indexer/v1/supervisors` instead of `/druid/indexer/v1/supervisor` so it
would have read a bit better, but that seems more painful than useful to change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
