egor-ryashin commented on a change in pull request #6357: Improve interning in
SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6357#discussion_r219331576
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
##########
@@ -535,6 +531,25 @@ public DataSegment map(int index, ResultSet r,
StatementContext ctx)
}
}
+ /**
+ * For the garbage collector in Java, it's better to keep new objects
short-living, but once they are old enough
+ * (i. e. promoted to old generation), try to keep them alive. In {@link
#poll()}, we fetch and deserialize all
+ * existing segments each time, and them replace them in {@link
#dataSourcesRef}. This method allows to use already
Review comment:
typo `them`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
