jihoonson commented on a change in pull request #6356: Fix indexes introduced
in #6348.
URL: https://github.com/apache/incubator-druid/pull/6356#discussion_r219642555
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java
##########
@@ -217,9 +217,13 @@ public void createPendingSegmentsTable(final String
tableName)
tableName, getPayloadType(), getQuoteString()
),
StringUtils.format(
- "CREATE INDEX idx_%1$s_datasource_used_end ON %1$s(dataSource,
used, %2$send%2$s)",
+ "CREATE INDEX idx_%1$s_datasource_end ON %1$s(dataSource,
%2$send%2$s)",
Review comment:
I wonder it's better to make an index for `dataSource, sequence_name, end`
because this combination is used when searching an existing segmentId in
`IndexerSQLMetadataStorageCoordinator.allocatePendingSegment()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
