leventov commented on a change in pull request #6349: maintenance mode for 
Historical
URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r220501009
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java
 ##########
 @@ -220,6 +245,7 @@ protected void moveSegment(
             segmentToMove,
 
 Review comment:
   Interesting that `DruidCoordinator.moveSegment()` also wraps pretty much 
it's whole body with `try { ... } catch (Exception e) { ...}`, that will makes 
`catch (Exception e)` below in *this* method obsolete. I think only one should 
be left.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to