leventov commented on a change in pull request #6349: maintenance mode for
Historical
URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r220495765
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -95,6 +100,8 @@ public CoordinatorDynamicConfig(
this.killDataSourceWhitelist =
parseJsonStringOrArray(killDataSourceWhitelist);
this.killPendingSegmentsSkipList =
parseJsonStringOrArray(killPendingSegmentsSkipList);
this.maxSegmentsInNodeLoadingQueue = maxSegmentsInNodeLoadingQueue;
+ this.maintenanceList = parseJsonStringOrArray(maintenanceList);
+ this.maintenanceModeSegmentsPriority = Math.min(10, Math.max(0,
maintenanceModeSegmentsPriority));
Review comment:
I think it should rather check bounds than saturating, to avoid silent
consume of configuration errors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
