leventov opened a new pull request #6385: Don't convert DruidServer to ImmutableDruidServers multiple times in DruidCoordinator URL: https://github.com/apache/incubator-druid/pull/6385 Previously `servers` was a lazy iterable, that converted `DruidServer` objects to `ImmutableDruidServer`s on each iteration, 2 or 3 times, if debug logging is enabled. I think it could lead to massive garbage production on coordinator, because each `toImmutableDruidServer()` call moves a lot of inventory to immutable collections.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
