QiuMM commented on a change in pull request #6386: Prohibit jackson
ObjectMapper#reader methods which are deprecated
URL: https://github.com/apache/incubator-druid/pull/6386#discussion_r220779762
##########
File path:
extensions-core/lookups-cached-single/src/test/java/org/apache/druid/server/lookup/cache/loading/LoadingCacheTest.java
##########
@@ -160,8 +160,8 @@ public void testIsClosed()
public void testSerDeser() throws IOException
{
ObjectMapper mapper = new DefaultObjectMapper();
- Assert.assertEquals(loadingCache,
mapper.reader(LoadingCache.class).readValue(mapper.writeValueAsString(loadingCache)));
- Assert.assertTrue(loadingCache.hashCode() ==
mapper.reader(LoadingCache.class).readValue(mapper.writeValueAsString(loadingCache)).hashCode());
+ Assert.assertEquals(loadingCache,
mapper.readerFor(LoadingCache.class).readValue(mapper.writeValueAsString(loadingCache)));
+ Assert.assertTrue(loadingCache.hashCode() ==
mapper.readerFor(LoadingCache.class).readValue(mapper.writeValueAsString(loadingCache)).hashCode());
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
