gianm commented on issue #6302: Add SQL id, request logs, and metrics
URL: https://github.com/apache/incubator-druid/pull/6302#issuecomment-424945060
 
 
   Hi @gaodayue, in the meantime could you please check the tests and 
inspections? In the tests, it looks like lots of CalciteQueryTests are failing 
due to the new `sqlQueryId`. Maybe the verifier that compares the queries for 
correctness should strip `sqlQueryId` first. In the inspections, it is 
reporting that the Query.getSqlQueryId() method is never used. If it's not 
needed, you can remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to