gaodayue commented on issue #6302: Add SQL id, request logs, and metrics
URL: https://github.com/apache/incubator-druid/pull/6302#issuecomment-425160329
 
 
   Thanks @gianm . I will fix all failed test cases ASAP. 
   
   > In the inspections, it is reporting that the Query.getSqlQueryId() method 
is never used. If it's not needed, you can remove it.
   
   That method is for custom QueryMetrics impls to add "sqlQueryId" dimension 
to the metrics. I add @SuppressWarnings("unused") to the signature, hope the 
inspection tool can understand it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to