jihoonson commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221126065
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -517,10 +532,9 @@ private DruidTable buildDruidTable(final String
dataSource)
return queryLifecycleFactory.factorize().runSimple(segmentMetadataQuery,
authenticationResult, null);
}
- private static RowSignature analysisToRowSignature(final SegmentAnalysis
analysis)
+ private static Pair<RowSignature, Long> analysisToRowSignature(final
SegmentAnalysis analysis)
Review comment:
Why does this return pair? `analysis.getNumRows()` should be available in
the caller as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
