jihoonson commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221118851
##########
File path:
benchmarks/src/main/java/org/apache/druid/benchmark/query/SqlBenchmark.java
##########
@@ -111,16 +114,20 @@ public void setup()
.createQueryRunnerFactoryConglomerate();
final QueryRunnerFactoryConglomerate conglomerate =
conglomerateCloserPair.lhs;
final PlannerConfig plannerConfig = new PlannerConfig();
+ final DruidLeaderClient druidLeaderClient =
EasyMock.createMock(DruidLeaderClient.class);
Review comment:
nit: I would suggest to add `NoopDruidLeaderClient` rather than mocking with
`EasyMock`. Even though this is not being used in this benchmark, I feel a bit
weird because EasyMock is mostly for testing purpose not for benchmark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
