nishantmonu51 commented on a change in pull request #6396: Implement
MapVirtualColumn.makeDimensionSelector properly
URL: https://github.com/apache/incubator-druid/pull/6396#discussion_r221134530
##########
File path:
processing/src/main/java/org/apache/druid/segment/data/SingleIndexedInt.java
##########
@@ -33,6 +33,11 @@ public SingleIndexedInt()
{
}
+ public SingleIndexedInt(int value)
Review comment:
I believe one of the reasons for not having this constr was to avoid people
creating new objects and reusing this class in the selectors, by caching an
instance and calling setValue() every time getObject is called from selector.
Can we do the same and use setValue instead of adding new constr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
