jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly URL: https://github.com/apache/incubator-druid/pull/6396#discussion_r221338751
########## File path: extensions-contrib/virtual-columns/src/main/java/org/apache/druid/segment/MapTypeMapVirtualColumnDimensionSelector.java ########## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.druid.segment; + +import com.google.common.base.Predicate; +import org.apache.druid.query.filter.ValueMatcher; +import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector; +import org.apache.druid.segment.data.IndexedInts; + +import javax.annotation.Nullable; +import java.util.Map; +import java.util.stream.Collectors; +import java.util.stream.IntStream; + +/** + * {@link DimensionSelector} for {@link Map} type {@link MapVirtualColumn}. This dimensionSelector only supports + * {@link #getObject()} currently. + */ +final class MapTypeMapVirtualColumnDimensionSelector extends MapVirtualColumnDimensionSelector +{ + MapTypeMapVirtualColumnDimensionSelector( + DimensionSelector keySelector, + DimensionSelector valueSelector + ) + { + super(keySelector, valueSelector); + } + + @Override + public IndexedInts getRow() + { + throw new UnsupportedOperationException("Map column doesn't support aggregation yet"); + } + + @Override + public ValueMatcher makeValueMatcher(@Nullable String value) + { + return new ValueMatcher() + { + @Override + public boolean matches() + { + // Map column doesn't match with any string + return false; + } + + @Override + public void inspectRuntimeShape(RuntimeShapeInspector inspector) + { + + } + }; + } + + @Override + public ValueMatcher makeValueMatcher(Predicate<String> predicate) + { + return new ValueMatcher() + { + @Override + public boolean matches() + { + return false; + } + + @Override + public void inspectRuntimeShape(RuntimeShapeInspector inspector) + { + + } + }; + } + + @Override + public int getValueCardinality() + { + return CARDINALITY_UNKNOWN; + } + + @Nullable + @Override + public String lookupName(int id) + { + return null; Review comment: Fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
