gianm commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221371033
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -320,25 +322,32 @@ public void awaitInitialization() throws
InterruptedException
private void addSegment(final DruidServerMetadata server, final DataSegment
segment)
{
synchronized (lock) {
- final Map<DataSegment, RowSignature> knownSegments =
segmentSignatures.get(segment.getDataSource());
+ final Map<DataSegment, SegmentMetadataHolder> knownSegments =
segmentMetadataInfo.get(segment.getDataSource());
if (knownSegments == null || !knownSegments.containsKey(segment)) {
+ final long isRealtime = server.segmentReplicatable() ? 0 : 1;
Review comment:
It's a pretty standard way in Druid of differentiating realtime and
non-realtime servers. See CoordinatorBasedSegmentHandoffNotifier, DruidSchema,
and CachingClusteredClient, all of which use this method to determine if
segments are served by realtime servers or not. Maybe we could make this
clearer by adding a new "isRealtimeServer" method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
