QiuMM commented on a change in pull request #6272: Add suspend|resume|terminate
all supervisors endpoints.
URL: https://github.com/apache/incubator-druid/pull/6272#discussion_r221419078
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResourceTest.java
##########
@@ -292,14 +292,6 @@ public void testSpecGetStatus()
@Test
public void testSpecSuspend()
{
-
- TestSupervisorSpec running = new TestSupervisorSpec("my-id", null, null,
false) {
- @Override
- public List<String> getDataSources()
- {
- return Collections.singletonList("datasource1");
- }
- };
Review comment:
The reason why I removed this is that I have moved the condition
`spec.get().isSuspended() == suspend` into
`SupervisorManager#possiblySuspendOrResumeSupervisorInternal` and modified the
implementation of `SupervisorResource#specSuspendOrResume` to keep consistent
with the implementation of `SupervisorResource#terminate`. After done these, I
have to modify the test code, then I found there was no need to keep this. You
can check the whole `SupervisorResourceTest#testSpecSuspend` then you'll find I
have tested both behaviors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
