egor-ryashin commented on issue #6370: Introduce SegmentId class URL: https://github.com/apache/incubator-druid/pull/6370#issuecomment-425655545 BTW, it would have been much easier to review if naming changes like `getIdentifier` -> `getId` and `Datasource` -> `DataSource` had been in a separate commit, as they affect large amount of code, which makes it somewhat challenging to get the picture of functional changes there.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
