jihoonson commented on a change in pull request #6383: Prevent failed KafkaConsumer creation from blocking overlord startup URL: https://github.com/apache/incubator-druid/pull/6383#discussion_r222189459
########## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java ########## @@ -260,6 +261,7 @@ public String toString() private volatile DateTime firstRunTime; private volatile KafkaConsumer consumer; + private volatile boolean lifecycleStarted = false; Review comment: > the idea of the patch was to keep the supervisor in a state similar to what it would have been in if it were stuck in the current lifecycle start, while allowing the rest of the lifecycle to start Got it. Makes sense. The reason I commented about `InitNotice` was, I'm not sure `initializationExec` is needed. Maybe we can use `scheduledExec` instead and cancel the scheduledFuture once `tryInit` succeeds? Or we can submit a runnable task to `exec` which calls `RetryUtils.retry()`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
