fjy commented on a change in pull request #6407: Add support
keepSegmentGranularity for automatic compaction
URL: https://github.com/apache/incubator-druid/pull/6407#discussion_r223196819
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/helper/NewestSegmentFirstIterator.java
##########
@@ -458,9 +401,14 @@ String getDataSource()
this.segments = segments;
}
- public List<DataSegment> getSegments()
+ List<DataSegment> getSegments()
{
return segments;
}
+
+ int size()
Review comment:
can we call this getSize() and explicitly list if it is
public/private/protected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
