leventov commented on a change in pull request #6402: Thread-safe QueryMetrics URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r223760739
########## File path: processing/src/main/java/org/apache/druid/query/QueryMetrics.java ########## @@ -92,7 +94,7 @@ * 100% guarantee of compatibility, because methods could not only be added to QueryMetrics, existing methods could also * be changed or removed. * - * <p>QueryMetrics is designed for use from a single thread, implementations shouldn't care about thread-safety. + * <p><b>All implementations of QueryMetrics should be Thread-safe.</b> Review comment: This is vague statement. Please describe all three different policies for reporting metrics, setting dimensions and `emit()`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
