clintropolis commented on a change in pull request #6432: Allow custom TLS cert
checks
URL: https://github.com/apache/incubator-druid/pull/6432#discussion_r224233954
##########
File path:
integration-tests/src/main/java/org/apache/druid/testing/ConfigFileConfigProvider.java
##########
@@ -114,6 +116,21 @@ private void loadProperties(String configFile)
noClientAuthRouterTLSUrl = StringUtils.format("https://%s:%s";,
noClientAuthRouterHost, props.get("router_no_client_auth_tls_port"));
}
}
+ customCertCheckRouterUrl = props.get("router_no_client_auth_url");
+ if (customCertCheckRouterUrl == null) {
+ String customCertCheckRouterHost =
props.get("router_no_client_auth_host");
+ if (null != customCertCheckRouterHost) {
Review comment:
nit: i find this kind of jarring since outer is `var == null` and then
inside it's flipped to `null != var`, but I don't think it's a big deal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
