dclim commented on a change in pull request #6285: Securing passwords used for
SSL connections to Kafka
URL: https://github.com/apache/incubator-druid/pull/6285#discussion_r224286053
##########
File path:
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorIOConfigTest.java
##########
@@ -119,6 +122,42 @@ public void testSerdeWithNonDefaults() throws Exception
Assert.assertTrue("skipOffsetGaps", config.isSkipOffsetGaps());
}
+ @Test
+ public void testSerdeForConsumerPropertiesWithPasswords() throws Exception
Review comment:
Sounds reasonable to me. We're not really interested in testing the
functionality of `EnvironmentVariablePasswordProvider` here, that should be
done in `EnvironmentVariablePasswordProviderTest` (but it doesn't look like it
actually tested it..)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
