himanshug commented on issue #6377: Use NodeType enum instead of Strings URL: https://github.com/apache/incubator-druid/pull/6377#issuecomment-429079234 I wish I was as confident about integration tests. In general, I think I try and test everything at least in a toy cluster when sending the PR and saying it was done from my side. Even that doesn't catch all problems but gives me as PR author some confidence.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
