gianm commented on issue #6431: Add Kinesis Indexing Service to core Druid URL: https://github.com/apache/incubator-druid/pull/6431#issuecomment-429115301 Thanks @jsun98 for being willing to add more detail to the PR description. I'd suggest including, - Definition of the abstractions being introduced & how they apply to Kafka and Kinesis. - Discussion of any other streaming systems you are aware of that these abstractions may (or may not) apply to. - Discussion of any approaches you considered when developing this (not sharing code at all, some other ways of sharing code) and why you chose the method you implemented. I think it will help people understand the approach you took and make it easier to review it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
