patelh commented on a change in pull request #6419: Add ability to specify dbcp
properties file
URL: https://github.com/apache/incubator-druid/pull/6419#discussion_r224925425
##########
File path:
common/src/main/java/org/apache/druid/metadata/MetadataStorageConnectorConfig.java
##########
@@ -78,6 +82,11 @@ public String getPassword()
return passwordProvider == null ? null : passwordProvider.getPassword();
}
+ public Properties getDbcpProperties()
+ {
+ return dbcpProperties;
Review comment:
I would prefer to do it, but then I feel conflicted since the rest of the
members aren't null checked and then don't want to break convention already set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
