drcrallen commented on a change in pull request #6415: Add period drop before
rule
URL: https://github.com/apache/incubator-druid/pull/6415#discussion_r226046813
##########
File path: server/src/main/resources/static/old-console/js/rules-0.0.2.js
##########
@@ -151,6 +155,10 @@ function makeDropByPeriod(rule) {
return "<span class='rule_label'>period</span><input type='text'
name='period' " + "value='" + rule.period + "'/>";
}
+function makeDropBeforeByPeriod(rule) {
+ return "<span class='rule_label'>period</span><input type='text'
name='period' " + "value='" + rule.period + "'/>";
Review comment:
would it make sense to put something more descriptive so it is clear this
`period` is different than the one above it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
