a2l007 opened a new issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486 Currently the comparison within `HavingSpecMetricComparator` is restricted to Long, Integer, Float, Double and String. For custom aggregators having a custom type, this comparison would fail with an exception as per: https://github.com/apache/incubator-druid/blob/master/processing/src/main/java/org/apache/druid/query/groupby/having/HavingSpecMetricComparator.java#L77 Instead of throwing an exception, I'd like to replace it with a default comparison using Double.compare. Any thoughts/objections @gianm @leventov ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
