drcrallen commented on issue #6469: Getting `druid.server.maxSize` out of the way URL: https://github.com/apache/incubator-druid/issues/6469#issuecomment-431075207 One use case I can see some issues is if you have multiple disks which in aggregate have enough free space, but none individually does. For example, lets say the free spaces for 10 disks were: 100MB, 100MB, 100MB, 100MB, 100MB, 100MB, 100MB, 100MB, 100MB, 100MB The coordinator might think it can hold 1GB worth of segments, when in reality it can't hold any segment larger than 100MB. ((This might actually be a problem even in the current implementation)) I know I've been bitten by the "disk space has to be set twice" problem a few times. That and the kilobyte vs kibibyte... As this is designed, please be sure to call out any corner cases that may arise. Suggest limiting scope to "sum of disks" problem for now, and leaving measurement in bytes. Anything that is "not worse than current and better in at least these cases" is very welcome.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
