surekhasaharan commented on a change in pull request #6467: add rule count on
log
URL: https://github.com/apache/incubator-druid/pull/6467#discussion_r226394840
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataRuleManager.java
##########
@@ -311,7 +311,8 @@ public void poll()
)
);
- log.info("Polled and found rules for %,d datasource(s)",
newRules.size());
+ int newRuleCount = newRules.values().stream().mapToInt(List::size).sum();
Review comment:
I'd say if you do not intend to change the value of the local variable, and
it could be final, then it should be final. It allows for better readability
and is a good practice in general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
