gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics
URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r227217110
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
 ##########
 @@ -260,13 +272,6 @@ public void identity(String identity)
     return reportMetric(metricName, TimeUnit.NANOSECONDS.toMillis(timeNs));
   }
 
-  protected QueryMetrics<QueryType> reportMetric(String metricName, Number 
value)
 
 Review comment:
   not removed, just moved it below setDimensions()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to