gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics
URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r227251555
##########
File path: processing/src/main/java/org/apache/druid/query/QueryPlus.java
##########
@@ -100,23 +100,11 @@ private QueryPlus(Query<T> query, QueryMetrics<?>
queryMetrics, String identity)
}
}
- /**
- * Returns a QueryPlus object without the components which are unsafe for
concurrent use from multiple threads,
- * therefore couldn't be passed down in concurrent or async {@link
QueryRunner}s.
- *
- * Currently the only unsafe component is {@link QueryMetrics}, i. e. {@code
withoutThreadUnsafeState()} call is
- * equivalent to {@link #withoutQueryMetrics()}.
- */
- public QueryPlus<T> withoutThreadUnsafeState()
- {
- return withoutQueryMetrics();
- }
-
/**
* Returns the same QueryPlus object, if it doesn't have {@link
QueryMetrics} ({@link #getQueryMetrics()} returns
Review comment:
add motivation to comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
