jihoonson edited a comment on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432367778 > The basic requirement is that for custom types, the compare method should not to throw an exception and handle it in a default way. Hmm, I think this would be best if the default behavior can handle most of types. But, in this case, I'm not sure there's a reasonable default behavior. So, I still think it makes more sense to throw an exception if the metric column is an unknown type. With #6505, it will throw the ClassCastException anyway if it can't be casted to Number. I wonder if you can explicitly cast the column in the having clause to double in your query. Does it make sense?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
