jon-wei commented on a change in pull request #6552: Use current coordinator
leader instead of cached one (#6551)
URL: https://github.com/apache/incubator-druid/pull/6552#discussion_r230873804
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##########
@@ -682,6 +694,49 @@ public void close()
);
}
+ private static void checkResponse(
+ ListenableFuture<InputStream> future,
+ Request request,
+ BytesAccumulatingResponseHandler responseHandler
+ )
+ {
+ Futures.addCallback(
+ future,
+ new FutureCallback<InputStream>()
+ {
+ @Override
+ public void onSuccess(@Nullable InputStream result)
+ {
+ if (responseHandler.getStatus() ==
HttpServletResponse.SC_NO_CONTENT) {
Review comment:
Did you observe that status code being returned on any API calls? It looks
like getDatabaseSegments in MetadataResource will always return at least an
empty JSON array with status OK, so getting SC_NO_CONTENT seems like an error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
