QiuMM commented on a change in pull request #6621: Enforce logging when killing
a task
URL: https://github.com/apache/incubator-druid/pull/6621#discussion_r233361104
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java
##########
@@ -839,8 +839,7 @@ private void killTasksInGroup(TaskGroup taskGroup)
{
if (taskGroup != null) {
for (String taskId : taskGroup.tasks.keySet()) {
- log.info("Killing task [%s] in the task group", taskId);
- killTask(taskId);
+ killTask(taskId, "Killing task [%s] in the task group[%s]", taskId,
taskGroup.groupId);
Review comment:
I think add a reason to explain why killing a task in a task group would be
better. Maybe modify `private void killTasksInGroup(TaskGroup taskGroup)` to
`private void killTasksInGroup(TaskGroup taskGroup, String reason)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
