asdf2014 removed a comment on issue #6623: Fetch offsets optimize URL: https://github.com/apache/incubator-druid/pull/6623#issuecomment-438590476 Hi, @hate13 . Thanks for your PR. :+1: Using the new Consumer API `endOffsets` does avoid competing lock. However, it would be better if you could provide a benchmark test for this PR. FYI, if the partition does not exist, the `endOffsets` method may block indefinitely, so we should also consider carefully choosing a reasonable value of the `request.timeout.ms` param.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
