gianm commented on a change in pull request #6617: Fix bugs in ExprEval
URL: https://github.com/apache/incubator-druid/pull/6617#discussion_r233660034
##########
File path: core/src/main/java/org/apache/druid/math/expr/ExprEval.java
##########
@@ -197,7 +197,7 @@ public final ExprEval castTo(ExprType castTo)
return this;
case LONG:
if (value == null) {
- return ExprEval.of(null);
+ return ExprEval.ofLong(null);
Review comment:
Oh, sorry, I misread your original comment. It is already fixed in 0.13.0 by
your other PR #6616. Sorry, I was confused by the fact that the backport had
stuff that wasn't in the original.
Well, please consider the comments anyway, if you can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
